Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver

From: Christophe Leroy
Date: Wed Jan 24 2024 - 08:03:17 EST




Le 24/01/2024 à 10:36, Kunwu Chan a écrit :
> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c")
> in about 14 years before.
> If there are no plans to enable this part code in the future,
> we can remove this dead code.
>
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
> ---
> arch/powerpc/kvm/book3s.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
> index 8acec144120e..c2f50e04eec8 100644
> --- a/arch/powerpc/kvm/book3s.c
> +++ b/arch/powerpc/kvm/book3s.c
> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kvm_vcpu *vcpu,
> break;
> }
>
> -#if 0
> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver);
> -#endif

Please also remove one of the two blank lines.

>
> if (deliver)
> kvmppc_inject_interrupt(vcpu, vec, 0);