RE: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.

From: Ratheesh Kannoth
Date: Wed Jan 24 2024 - 05:44:30 EST


> From: Simon Horman <horms@xxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
>
> I think the question is: if the devm_kfree() calls are removed, then is the
> lifecycle of the objects in question managed correctly?
If lifecycle of the objects are managed correctly without devm_kfree(), why this API is
Provided and exported in kernel ?

>
> > 2. I could see instances of devm_kfree() usage in current kernel where it
> does explicit calls.
>
> Sure. But in this case the use of devm_* doesn't seem to be adding anything
> if the memory is _always_ freed by explicit calls to devm_kfree().
I got it. I would like to keep the diff minimal (rather than deleting lines diff). would this be okay ?