Re: [linus:master] [mm] 8d59d2214c: vm-scalability.throughput -36.6% regression

From: Yosry Ahmed
Date: Wed Jan 24 2024 - 04:12:48 EST


On Wed, Jan 24, 2024 at 12:26 AM Oliver Sang <oliver.sang@xxxxxxxxx> wrote:
>
> hi, Yosry Ahmed,
>
> On Mon, Jan 22, 2024 at 11:42:04PM -0800, Yosry Ahmed wrote:
> > > > Oliver, would you be able to test if the attached patch helps? It's
> > > > based on 8d59d2214c236.
> > >
> > > the patch failed to compile:
> > >
> > > build_errors:
> > > - "mm/memcontrol.c:731:38: error: 'x' undeclared (first use in this function)"
> >
> > Apologizes, apparently I sent the patch with some pending diff in my
> > tree that I hadn't committed. Please find a fixed patch attached.
>
> the regression disappears after applying the patch.
>
> Tested-by: kernel test robot <oliver.sang@xxxxxxxxx>

Awesome! Thanks for testing. I will formalize the patch and send it
out for review.