RE: [PATCH v3 2/2] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests

From: David Laight
Date: Wed Jan 24 2024 - 04:08:04 EST


From: Charlie Jenkins
> Sent: 24 January 2024 00:39
>
> The test cases for ip_fast_csum and csum_ipv6_magic were using arbitrary
> alignment of data to iterate through random inputs. ip_fast_csum should
> have the data aligned along (14 + NET_IP_ALIGN) bytes and
> csum_ipv6_magic should have data aligned along 32-bit boundaries.
>
...
> + 0x9359, 0x5630, 0xd659, 0x5b4d, 0x511e, 0x627c, 0x4e30, 0x73f1, 0x63c,
> + 0xf2da, 0x7b, 0xa98b, 0x4fb7, 0x87a6, 0x2500, 0x34e4, 0xf0cd, 0xdc69,
> + 0x7bde, 0x73f0, 0xd85d, 0x722d, 0x9776, 0x3c8, 0x7e07, 0xdca9, 0x9ecc,
> + 0xc6c0, 0xbec1, 0x8de5, 0x6f7f, 0x1a09, 0xdbe6, 0x7c4b, 0x3787, 0xdb38,
> + 0xfac, 0xbed9, 0x3039, 0x6501, 0xae1a, 0xed89, 0xd982, 0xc530, 0xccf6,
> + 0xd888, 0xf369, 0x2c4e, 0x38c0, 0xcff5, 0xdc9d, 0x5998, 0xe0d1, 0x7e23,

I'm seeing some odd alignment in that table.
I think there are 'random' tabs following short constants.
(Not helped by outuck deciding that tabs are 6 spaces!)
Probably better to add leading spaces (or zeros after the 0x).

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)