Re: [v2 1/4] KVM: irqchip: add setup empty irq routing function

[Yi Wang]

On Wed, Jan 24, 2024 at 2:47 AM Oliver Upton <oliver.upton@xxxxxxxxx> wrote:
>
> On Sun, Jan 21, 2024 at 07:17:27PM +0800, Yi Wang wrote:
> > Add a new function to setup empty irq routing in kvm path, which
> > can be invoded in non-architecture-specific functions. The difference
> > compared to the kvm_setup_empty_irq_routing() is this function just
> > alloc the empty irq routing and does not need synchronize srcu, as
> > we will call it in kvm_create_vm().
> >
> > This patch is a preparatory step for an upcoming patch to avoid
> > delay in KVM_CAP_SPLIT_IRQCHIP ioctl.
>
> Adding a function in a separate patch from its callsites is never
> useful. Please squash this into the second patch.

Thanks for your review and suggestion. I will update this patch ASAP.

>
> --
> Thanks,
> Oliver



-- 
---
Best wishes
Yi Wang