Re: [PATCH] rust: str: add to_ascii_{upper,lower}case() to CString

[Miguel Ojeda]

On Mon, Jan 22, 2024 at 11:16 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> If preferred, I can add this to the commit message.

Ah, yeah, I meant in the commit message. Thanks!

> Mimic, as in copy them over (to the extent they actually apply)?

Yeah -- well, if you think they are better (sometimes they may be,
i.e. I typically mention it when we have something close to the
standard library as a potential source for inspiration).

> Sure, I'm fine adding them as well. Not sure we'll need them for Nova though.

Up to you -- I think either way would be fine, i.e. I would say it is
reasonable to think the others would be useful if these already have a
user (similarly, say, not adding `uppercase` because we only have a
`lowercase` use so far sounds a bit too strict I guess).

In fact, in the Zulip use case you showed, you were using the
new-object one rather than the in-place, no? Or that changed?

Cheers,
Miguel