Re: [PATCH v2 2/2] arm64: dts: qcom: sm8550: add support for the SM8550-HDK board

[Neil Armstrong]

On 23/01/2024 14:02, Neil Armstrong wrote:
> On 23/01/2024 10:10, Dmitry Baryshkov wrote:
> > On Tue, 23 Jan 2024 at 10:56, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
> > > The SM8550-HDK is an embedded development platforms for the
> > > Snapdragon 8 Gen 2 SoC aka SM8550, with the following features:
> > > - Qualcomm SM8550 SoC
> > > - 16GiB On-board LPDDR5
> > > - On-board WiFi 7 + Bluetooth 5.3/BLE
> > > - On-board UFS4.0
> > > - M.2 Key B+M Gen3x2 PCIe Slot
> > > - HDMI Output
> > > - USB-C Connector with DP Almode & Audio Accessory mode
> > > - Micro-SDCard Slot
> > > - Audio Jack with Playback and Microphone
> > > - 2 On-board Analog microphones
> > > - 2 On-board Speakers
> > > - 96Boards Compatible Low-Speed and High-Speed connectors [1]
> > >    - For Camera, Sensors and external Display cards
> > >    - Compatible with the Linaro Debug board [2]
> > > - SIM Slot for Modem
> > > - Debug connectors
> > > - 6x On-Board LEDs
> > >
> > > Product Page: [3]
> > >
> > > [1] https://www.96boards.org/specifications/
> > > [2] https://git.codelinaro.org/linaro/qcomlt/debugboard
> > > [3] https://www.lantronix.com/products/snapdragon-8-gen-2-mobile-hardware-development-kit/
> > >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/Makefile       |    1 +
> > >   arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 1290 +++++++++++++++++++++++++++++++
> > >   2 files changed, 1291 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > > index 39889d5f8e12..42e50f2b2ec3 100644
> > > --- a/arch/arm64/boot/dts/qcom/Makefile
> > > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > > @@ -233,6 +233,7 @@ dtb-$(CONFIG_ARCH_QCOM)     += sm8450-hdk.dtb
> > >   dtb-$(CONFIG_ARCH_QCOM)        += sm8450-qrd.dtb
> > >   dtb-$(CONFIG_ARCH_QCOM)        += sm8450-sony-xperia-nagara-pdx223.dtb
> > >   dtb-$(CONFIG_ARCH_QCOM)        += sm8450-sony-xperia-nagara-pdx224.dtb
> > > +dtb-$(CONFIG_ARCH_QCOM)        += sm8550-hdk.dtb
> > >   dtb-$(CONFIG_ARCH_QCOM)        += sm8550-mtp.dtb
> > >   dtb-$(CONFIG_ARCH_QCOM)        += sm8550-qrd.dtb
> > >   dtb-$(CONFIG_ARCH_QCOM)        += sm8650-mtp.dtb
> > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> > > new file mode 100644
> > > index 000000000000..66bdd6c269ea
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> > > @@ -0,0 +1,1290 @@

<snip>

> > > +
> > > +&qupv3_id_0 {
> > > +       status = "okay";
> > > +};
> > > +
> > > +&qupv3_id_1 {
> > > +       status = "okay";
> > > +};
> >
> > BTW, don't we need to enable gpi_dma nodes for qup / i2c to work?
>
> Good question, for i2c_mater_hib no, but for i2c0 it should be enabled

OK I understood, i2c0 is configured to use FIFO so not having gpi dma enabled doesn't fail. I'll still enable it.

Neil


<snip>