Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync"

[Thomas Zimmermann]

Hi

Am 23.01.24 um 14:12 schrieb Huacai Chen:
> I'm very sorry to hear that, If Jaak can respond, I think I can find
> the root cause and fix that...

No problem, don't worry. We wanted to revert that patch anyway. And the 
*real* fix here is to track the framebuffer ownership more closely.

Best regards
Thomas

> Huacai
>
> On Tue, Jan 23, 2024 at 8:09 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:
> > This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4.
> >
> > Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from
> > device_initcall to subsys_initcall_sync") messes up initialization order
> > of the graphics drivers and leads to blank displays on some systems. So
> > revert the commit.
> >
> > To make the display drivers fully independent from initialization
> > order requires to track framebuffer memory by device and independently
> > from the loaded drivers. The kernel currently lacks the infrastructure
> > to do so.
> >
> > Reported-by: Jaak Ristioja <jaak@xxxxxxxxxxx>
> > Closes: https://lore.kernel.org/dri-devel/ZUnNi3q3yB3zZfTl@P70.localdomain/T/#t
> > Reported-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > Closes: https://lore.kernel.org/dri-devel/20231108024613.2898921-1-chenhuacai@xxxxxxxxxxx/
> > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10133
> > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> > Cc: Thorsten Leemhuis <regressions@xxxxxxxxxxxxx>
> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/firmware/sysfb.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c
> > index 82fcfd29bc4d2..3c197db42c9d9 100644
> > --- a/drivers/firmware/sysfb.c
> > +++ b/drivers/firmware/sysfb.c
> > @@ -128,4 +128,4 @@ static __init int sysfb_init(void)
> >   }
> >
> >   /* must execute after PCI subsystem for EFI quirks */
> > -subsys_initcall_sync(sysfb_init);
> > +device_initcall(sysfb_init);
> > --
> > 2.43.0

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature