Re: [PATCH 2/2] arm64: dts: qcom: qcm6490-idp: add display and panel

[Ritesh Kumar]

On 1/16/2024 3:28 PM, Dmitry Baryshkov wrote:

> On Tue, 16 Jan 2024 at 11:49, Ritesh Kumar <quic_riteshk@xxxxxxxxxxx> wrote:
> > Enable Display Subsystem with Novatek NT36672E Panel
> > on qcm6490 idp platform.
> Is this panel always present on the IDP board or is it an optional
> addon, like the panels for all the RBn boards?

This panel is always present on the IDP board.

> > Signed-off-by: Ritesh Kumar <quic_riteshk@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 100 +++++++++++++++++++++++
> >   1 file changed, 100 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > index 2a6e4907c5ee..efa5252130a1 100644
> > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > @@ -9,6 +9,7 @@
> >   #define PM7250B_SID 8
> >   #define PM7250B_SID1 9
> >
> > +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> >   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >   #include "sc7280.dtsi"
> >   #include "pm7250b.dtsi"
> > @@ -38,6 +39,25 @@
> >                  stdout-path = "serial0:115200n8";
> >          };
> >
> > +       lcd_disp_bias: lcd-disp-bias-regulator {
> > +               compatible = "regulator-fixed";
> > +               regulator-name = "lcd_disp_bias";
> > +               regulator-min-microvolt = <5500000>;
> > +               regulator-max-microvolt = <5500000>;
> > +               gpio = <&pm7250b_gpios 2 GPIO_ACTIVE_HIGH>;
> > +               enable-active-high;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&lcd_disp_bias_en>;
> > +       };
> > +
> > +       pm8350c_pwm_backlight: backlight {
> > +               compatible = "pwm-backlight";
> > +               pwms = <&pm8350c_pwm 3 65535>;
> > +               enable-gpios = <&pm8350c_gpios 7 GPIO_ACTIVE_HIGH>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pmic_lcd_bl_en>;
> > +       };
> > +
> >          reserved-memory {
> >                  xbl_mem: xbl@80700000 {
> >                          reg = <0x0 0x80700000 0x0 0x100000>;
> > @@ -420,6 +440,86 @@
> >          };
> >   };
> >
> > +&gpu {
> > +       status = "disabled";
> > +};
> > +
> > +&mdss {
> > +       status = "okay";
> > +};
> > +
> > +&mdss_dsi {
> > +       vdda-supply = <&vreg_l6b_1p2>;
> > +       status = "okay";
> > +
> > +       panel@0 {
> > +               compatible = "novatek,nt36672e";
> > +               reg = <0>;
> > +
> > +               reset-gpios = <&tlmm 44 GPIO_ACTIVE_HIGH>;
> > +
> > +               vddi-supply = <&vreg_l8c_1p62>;
> > +               avdd-supply = <&lcd_disp_bias>;
> > +               avee-supply = <&lcd_disp_bias>;
> > +
> > +               backlight = <&pm8350c_pwm_backlight>;
> > +
> > +               port {
> > +                       panel0_in: endpoint {
> > +                               remote-endpoint = <&mdss_dsi0_out>;
> > +                       };
> > +               };
> > +       };
> > +};
> > +
> > +&mdss_dsi0_out {
> > +       remote-endpoint = <&panel0_in>;
> > +       data-lanes = <0 1 2 3>;
> > +};
> > +
> > +&mdss_dsi_phy {
> > +       vdds-supply = <&vreg_l10c_0p88>;
> > +       status = "okay";
> > +};
> > +
> > +&pm7250b_gpios {
> > +       lcd_disp_bias_en: lcd-disp-bias-en-state {
> > +               pins = "gpio2";
> > +               function = "func1";
> > +               bias-disable;
> > +               qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
> > +               input-disable;
> > +               output-enable;
> > +               power-source = <0>;
> > +       };
> > +};
> > +
> > +&pm8350c_gpios {
> > +       pmic_lcd_bl_en: pmic-lcd-bl-en-state {
> > +               pins = "gpio7";
> > +               function = "normal";
> > +               bias-disable;
> > +               qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
> > +               output-low;
> > +               power-source = <0>;
> > +       };
> > +
> > +       pmic_lcd_bl_pwm: pmic-lcd-bl-pwm-state {
> > +               pins = "gpio8";
> > +               function = "func1";
> > +               bias-disable;
> > +               qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
> > +               output-low;
> > +               power-source = <0>;
> > +       };
> > +};
> > +
> > +&pm8350c_pwm {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pmic_lcd_bl_pwm>;
> > +       status = "okay";
> > +};
> > +
> >   &qupv3_id_0 {
> >          status = "okay";
> >   };
> > --
> > 2.17.1

Thanks,
Ritesh