RE: [PATCH 1/2] dt-bindings: gpio: add adg1414

From: Paller, Kim Seer
Date: Tue Jan 23 2024 - 04:56:31 EST


Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Monday, January 22, 2024 8:40 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>; Bartosz Golaszewski
> <brgl@xxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>
> Subject: Re: [PATCH 1/2] dt-bindings: gpio: add adg1414
>
> [External]
>
> On 21/01/2024 11:35, Kim Seer Paller wrote:
> > The ADG1414 is a 9.5 Ω RON ±15 V/+12 V/±5 V iCMOS Serially-Controlled
> > Octal SPST Switches
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > ---
> > .../bindings/gpio/gpio-adg1414.yaml | 66 +++++++++++++++++++
> > MAINTAINERS | 6 ++
> > 2 files changed, 72 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml
> > b/Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml
> > new file mode 100644
> > index 000000000..24a51e79f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/gpio-adg1414.yaml
>
> Filename like compatible.

I would like to clarify, is it changing the filename from gpio-adg1414.yaml
to adg1414.yaml?

> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +https://urldefense.com/v3/__http://devicetree.org/schemas/gpio/gpio-a
> > +dg1414.yaml*__;Iw!!A3Ni8CS0y2Y!_Q0zRB8J-
> inWIIybgOjtThU0toJeUzqaT9Tveg
> > +XTjvPWiCTh4IAJ5DkNepFdfhXXfxXLnB2wSR9_LgPnvVnFqw2bDuvBI8g$
> > +$schema:
> > +https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.y
> > +aml*__;Iw!!A3Ni8CS0y2Y!_Q0zRB8J-
> inWIIybgOjtThU0toJeUzqaT9TvegXTjvPWiC
> > +Th4IAJ5DkNepFdfhXXfxXLnB2wSR9_LgPnvVnFqw2bEIZ1PG4$
> > +
> > +title: ADG1414 SPST Switch Driver
>
> "Driver" as Linux driver or some hardware driver?

Linux device driver. It seems I overlooked this one, it should be ADG1414 Octal SPST Switches

> > +
> > +maintainers:
> > + - Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > +

Best regards,
Kim