Re: [BUG] BUG: kernel NULL pointer dereference at ttm_device_init+0xb4

[Christian König]

Am 23.01.24 um 03:52 schrieb Steven Rostedt:
> On Tue, 23 Jan 2024 12:32:39 +1000
> Dave Airlie <airlied@xxxxxxxxx> wrote:
>
> > On Tue, 23 Jan 2024 at 12:21, Dave Airlie <airlied@xxxxxxxxx> wrote:
> > > On Tue, 23 Jan 2024 at 12:15, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > > > On Mon, 22 Jan 2024 19:56:08 -0500
> > > > "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@xxxxxxx> wrote:
> > > >   
> > > > > On 1/22/2024 7:43 PM, Linus Torvalds wrote:
> > > > > > On Mon, 22 Jan 2024 at 15:17, Steven Rostedt<rostedt@xxxxxxxxxxx>  wrote:
> > > > > > > Perhaps this is the real fix?
> > > > > > If you send a signed-off version, I'll apply it asap.
> > > > >
> > > > > I think a fix might already be in flight. Please see Linux-Kernel
> > > > > Archive: Re: [PATCH] drm/ttm: fix ttm pool initialization for
> > > > > no-dma-device drivers (iu.edu)
> > > > > <https://lkml.iu.edu/hypermail/linux/kernel/2401.1/06778.html>
> > > > Please use lore links. They are much easier to follow and use.
> > > https://lore.kernel.org/dri-devel/20240123022015.1288588-1-airlied@xxxxxxxxx/T/#u
> > >
> > > should also fix it, Linus please apply it directly if Steven has a
> > > chance to give it a run.
> > I see Linus applied the other one, that's fine too.
> They don't look mutually exclusive. I can test the other one as well.

While applying the fix a week ago I was under the impression that QXL 
doesn't use a device structure because it doesn't have one and so can't 
give anything meaningful for this parameter.

If QXL does have a device structure and can provide it I would rather 
like to go down this route and make the device and with it the numa node 
mandatory for drivers to specify.

Regards,
Christian.

> -- Steve