Re: [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"

[Conor Dooley]

On Mon, Jan 22, 2024 at 07:40:51PM +0000, Mark Brown wrote:
> On Mon, Jan 22, 2024 at 06:00:14PM +0000, Conor Dooley wrote:
> > On Mon, Jan 22, 2024 at 05:56:49PM +0800, Seven Lee wrote:
> 
> > > +    enum:
> > > +      - 0 # VDDA
> > > +      - 1 # VDDA*1.5/1.8V
> > > +      - 2 # VDDA*1.6/1.8V
> > > +      - 3 # VDDA*1.7/1.8V
> 
> > I would also rather than this enum was used to have sensible values for
> > the enum itself (which I suppose means strings here), rather than the
> > register values. Seeing "nuvoton,dac-vref = <2>" in a devicetree is not
> > very meaningful IMO.
> 
> Do you have a concrete suggestion for how to more clearly write these
> directly?

I would use what's been given as the explanation comments for each of
the current enum values in the patch.

Attachment: signature.asc
Description: PGP signature