RE: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec

From: Wei Fang
Date: Mon Jan 22 2024 - 21:14:49 EST


> -----Original Message-----
> From: Breno Leitao <leitao@xxxxxxxxxx>
> Sent: 2024年1月23日 2:46
> To: kuba@xxxxxxxxxx; davem@xxxxxxxxxxxxx; abeni@xxxxxxxxxx;
> edumazet@xxxxxxxxxx; Wei Fang <wei.fang@xxxxxxx>; Shenwei Wang
> <shenwei.wang@xxxxxxx>; Clark Wang <xiaoning.wang@xxxxxxx>;
> dl-linux-imx <linux-imx@xxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: dsahern@xxxxxxxxxx; weiwan@xxxxxxxxxx; open list:FREESCALE IMX /
> MXC FEC DRIVER <netdev@xxxxxxxxxxxxxxx>; open list
> <linux-kernel@xxxxxxxxxxxxxxx>
> Subject: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec
>
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the FEC (MPC8xx) Ethernet controller.
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d42594f32275..c56807b757dc 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {
>
> module_platform_driver(fec_driver);
>
> +MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet
> driver");

Thank you very much for this patch. It would be better if you change the
description to " NXP Fast Ethernet Controller (FEC) driver".

> MODULE_LICENSE("GPL");
> --
> 2.39.3