Re: [PATCH] tick-sched: fix idle and iowait sleeptime accounting vs CPU hotplug

From: Tim Chen
Date: Mon Jan 22 2024 - 18:33:38 EST


On Mon, 2024-01-22 at 23:31 +0100, Frederic Weisbecker wrote:
> Le Mon, Jan 22, 2024 at 10:19:30AM -0800, Tim Chen a écrit :
> > On Mon, 2024-01-15 at 17:35 +0100, Heiko Carstens wrote:
> > >
> > >
> > > + idle_sleeptime = ts->idle_sleeptime;
> > > + iowait_sleeptime = ts->iowait_sleeptime;
> > > memset(ts, 0, sizeof(*ts));
> > > + ts->idle_sleeptime = idle_sleeptime;
> > > + ts->iowait_sleeptime = iowait_sleeptime;
> > > }
> >
> > Should idle_calls and idle_sleeps be preserved and
> > restored too?  
> >
> > Seems like if we preserve the
> > idle_sleeptime, and wish to compute the average
> > sleep time per sleep, we will need to know the value of
> > idle_sleeps that's also preserved across CPU offline/online.
>
> I guess those can be saved as well. Would you like to send the patch?
>

Okay, sent the patch in a separate email.

Tim