[PATCH v5 net-next 12/13] net: phy: marvell-88q2xxx: cleanup mv88q2xxx_config_init

From: Dimitri Fedrau
Date: Mon Jan 22 2024 - 16:33:52 EST


mv88q2xxx_config_init calls genphy_c45_read_pma which is done by
mv88q2xxx_read_status, it calls also mv88q2xxx_config_aneg which is
also called by the PHY state machine. Let the PHY state machine handle
the phydriver ops in their intendend way.

Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx>
---
drivers/net/phy/marvell-88q2xxx.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c
index e40ea351fcde..081ed110c87e 100644
--- a/drivers/net/phy/marvell-88q2xxx.c
+++ b/drivers/net/phy/marvell-88q2xxx.c
@@ -367,20 +367,13 @@ static int mv88q2xxx_config_aneg(struct phy_device *phydev)

static int mv88q2xxx_config_init(struct phy_device *phydev)
{
- int ret;
-
/* The 88Q2XXX PHYs do have the extended ability register available, but
* register MDIO_PMA_EXTABLE where they should signalize it does not
* work according to specification. Therefore, we force it here.
*/
phydev->pma_extable = MDIO_PMA_EXTABLE_BT1;

- /* Read the current PHY configuration */
- ret = genphy_c45_read_pma(phydev);
- if (ret)
- return ret;
-
- return mv88q2xxx_config_aneg(phydev);
+ return 0;
}

static int mv88q2xxx_get_sqi(struct phy_device *phydev)
--
2.39.2