Re: [PATCH iwl v2] i40e: print correct hw max rss count in kernel ring buffer

From: Simon Horman
Date: Mon Jan 22 2024 - 15:51:51 EST


On Sat, Jan 20, 2024 at 12:58:06PM +0530, Suresh Kumar wrote:
> pf->rss_size_max is hardcoded and always prints max rss count as 64.
>
> Eg:
> kernel: i40e 0000:af:00.1: User requested queue count/HW max RSS count: 104/64
>
> whereas ethtool reports the correct value from "vsi->num_queue_pairs"
>
> Channel parameters for eno33:
> Pre-set maximums:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104
> Current hardware settings:
> RX: n/a
> TX: n/a
> Other: 1
> Combined: 104 <-------
>
> and is misleading.
>
> Change it to vsi->num_queue_pairs
>
> Signed-off-by: Suresh Kumar <suresh2514@xxxxxxxxx>

Hi Suresh,

following-up on our earlier emails.

I do think that if this it is a fix it should have a fixes tag.
Which should be for the commit where the bug was first visible to users.