Re: [PATCH 1/2] dt-bindings: timer: nxp,sysctr-timer: support i.MX95

[Conor Dooley]

On Mon, Jan 22, 2024 at 05:22:24PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> i.MX95 System counter module has similar design as i.MX93, so add
> fallback compatible with nxp,sysctr-timer

It would be good, in my opinion, to add some device specific compatibles
and deprecate using "sysctr-timer" in isolation.

> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>

Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Cheers,
Conor.

> ---
>  .../devicetree/bindings/timer/nxp,sysctr-timer.yaml         | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml b/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml
> index 2b9653dafab8..4f0b660d5ce3 100644
> --- a/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/nxp,sysctr-timer.yaml
> @@ -18,7 +18,11 @@ description: |
>  
>  properties:
>    compatible:
> -    const: nxp,sysctr-timer
> +    oneOf:
> +      - const: nxp,sysctr-timer
> +      - items:
> +          - const: nxp,imx95-sysctr-timer
> +          - const: nxp,sysctr-timer
>  
>    reg:
>      maxItems: 1
> -- 
> 2.37.1
>

Attachment: signature.asc
Description: PGP signature