Re: [PATCH 6/8] net: mdio: ipq4019: support reset control

[Ziyang Huang]

在 2024/1/22 0:35, Andrew Lunn 写道:
> On Sun, Jan 21, 2024 at 08:42:35PM +0800, Ziyang Huang wrote:
>
> In this case, you need to document why the MDIO core reset controller
> code does not work for you.
>
> You are also missing the device tree binding again.

Sorry. Will write it.

> > @@ -248,6 +254,10 @@ static int ipq4019_mdio_probe(struct platform_device *pdev)
> >   	if (IS_ERR(priv->membase))
> >   		return PTR_ERR(priv->membase);
> >   
> > +	priv->rst = devm_reset_control_array_get_optional_exclusive(&pdev->dev);
> > +	if (IS_ERR(priv->rst))
> > +		return PTR_ERR(priv->rst);
>
> How many resets does this MDIO controller have? Would
> devm_reset_control_get_optional_exclusive() be sufficient.

Will explain in the following email.

>      Andrew
>
> ---
> pw-bot: cr