Re: [PATCH v3 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support

From: Robert Foss
Date: Mon Jan 22 2024 - 11:58:02 EST


On Sun, Nov 19, 2023 at 11:15 AM Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 52d91a0df..aca5bb086 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct dw_hdmi *hdmi)
> init_completion(&i2c->cmp);
>
> adap = &i2c->adap;
> - adap->class = I2C_CLASS_DDC;
> adap->owner = THIS_MODULE;
> adap->dev.parent = hdmi->dev;
> adap->algo = &dw_hdmi_algorithm;
>

Acked-by: Robert Foss <rfoss@xxxxxxxxxx>