Re: [PATCH 1/6] arm64: dts: qcom: ipq9574: Add PPE device tree node

[Jie Luo]

On 1/12/2024 10:51 PM, Krzysztof Kozlowski wrote:
> On 12/01/2024 15:40, Jie Luo wrote:
> > >   From the first glance, the bindings do not follow upstream principles.
> > > You have all the settings (tdm, port config, etc) in the DT, while
> > > they should instead go to the driver. Well, unless you expect that the
> > > board might need to override them.
> > Hi Dmitry,
> > The TDM configuration varies per SoC type, since the ethernet port
> > capabilities of the SoCs vary. So we will have two different TDM
> > configurations for IPQ5332 and IPQ9574 SoC. The driver also will
> > need to support future SoC, so we choose to configure this from the
> > DTSI. The same reason applies to the port scheduler config as well.
>
> Your statements here confirm Dmitry suggestion, so these are not board
> specific and should go to the driver. Please read again Dmitry's sentences.
>
> Best regards,
> Krzysztof

Sure, we will update the driver to configure the TDM depending on the 
SoC need.