Re: [PATCH] ixgbe: Fix an error handling path in ixgbe_read_iosf_sb_reg_x550()

From: Simon Horman
Date: Mon Jan 22 2024 - 06:20:56 EST


On Sat, Jan 20, 2024 at 06:25:36PM +0100, Christophe JAILLET wrote:
> All error handling paths, except this one, go to 'out' where
> release_swfw_sync() is called.
> This call balances the acquire_swfw_sync() call done at the beginning of
> the function.
>
> Branch to the error handling path in order to correctly release some
> resources in case of error.
>
> Fixes: ae14a1d8e104 ("ixgbe: Fix IOSF SB access issues")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>