Re: [PATCH v2 1/2] dt-bindings: usb: mt6360-tcpc: Drop interrupt-names

[AngeloGioacchino Del Regno]

Il 19/01/24 17:32, Conor Dooley ha scritto:
> On Fri, Jan 19, 2024 at 10:41:04AM +0100, AngeloGioacchino Del Regno wrote:
> > This IP has only one interrupt, hence interrupt-names is not necessary
> > to have.
> > Since there is no user yet, simply remove interrupt-names.
>
> I'm a bit confused chief. Patch 2 in this series removes a user of this
> property from a driver, so can you explain how this statement is true?
>
> Maybe I need to drink a few cans of Monster and revisit this patchset?

What I mean with "there is no user" is that there's no device tree with any
mt6360-tcpc node upstream yet, so there is no meaningful ABI breakage.
Different story would be if there was a device tree using this already, in
which case, you can make a required property optional but not remove it.

Anything wrong?! :-)

Cheers,
Angelo


> Thanks,
> Conor.
>
> > ---
> >   .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml        | 5 -----
> >   1 file changed, 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > index 053264e60583..339bc9c00ac0 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > @@ -22,10 +22,6 @@ properties:
> >     interrupts:
> >       maxItems: 1
> >   
> > -  interrupt-names:
> > -    items:
> > -      - const: PD_IRQB
> > -
> >     connector:
> >       type: object
> >       $ref: ../connector/usb-connector.yaml#
> > @@ -58,7 +54,6 @@ examples:
> >           tcpc {
> >             compatible = "mediatek,mt6360-tcpc";
> >             interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
> > -          interrupt-names = "PD_IRQB";
> >   
> >             connector {
> >               compatible = "usb-c-connector";
> > --
> > 2.43.0