Re: [PATCH v5 2/3] dt-bindings: iio: light: Avago APDS9306

[Subhajit Ghosh]

On 22/1/24 02:06, Jonathan Cameron wrote:
> On Sun, 21 Jan 2024 15:47:33 +1030
> Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> wrote:
>
> > Adding device tree support for APDS9306 Ambient Light Sensor.
> > Updating datasheet hyperlinks.
> > Adding interrupt definition macro and header file.
>
> This is an unrelated change, so should probably be in a separate patch.
Understood.
> > Adding vdd-supply property.
>
> This one is reasonable to have in same patch as the new device addition
> as, whilst I assume it's valid for the existing devices, you are adding it
> to incorporate something that device also has.
> Could also be a separate precursor patch.
>
> >

> >   
> >   description: |
> > -  Datasheet: https://www.avagotech.com/docs/AV02-1077EN
> > -  Datasheet: https://www.avagotech.com/docs/AV02-4191EN
> > +  Datasheet: https://docs.broadcom.com/doc/AV02-1077EN
> > +  Datasheet: https://docs.broadcom.com/doc/AV02-4191EN
> > +  Datasheet: https://docs.broadcom.com/doc/AV02-4755EN
>
> Old links seem to still work, so why the change?
My bad. I will revert to keep things simple. No reason, just thought of updating.

Thanks for the review.

Regards,
Subhajit Ghosh