Re: [PATCH 1/4] ARM: dts: qcom: msm8974-samsung-klte: Add label on /i2c-gpio-led

From: Krzysztof Kozlowski
Date: Mon Jan 22 2024 - 04:50:05 EST


On 21/01/2024 16:39, Rong Zhang wrote:
> Some variants of klte, e.g., the China edition (kltechn), have minor
> differences to differentiate them from klte. This includes the GPIO pins
> connected to /i2c-gpio-led.
>
> A label is added on /i2c-gpio-led to allow DT of other variants to
> reference it conveniently. Considering both LEDs and a GPIO expander are
> connected to the node, it is named "i2c_led_gpio".
>
> Signed-off-by: Rong Zhang <i@xxxxxxxx>
> ---
> arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> index b93539e2b87e..013946ccda0f 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> @@ -77,7 +77,7 @@ touchkey@20 {
> };
> };
>
> - i2c-gpio-led {
> + i2c_led_gpio: i2c-gpio-led {

This does not make much sense on its own. 6 commit msg lines just to add
a label. Squash it.

Best regards,
Krzysztof