Re: [RFC PATCH v2 2/3] net: ti: icssg-switch: Add switchdev based driver for ethernet switch support

[MD Danish Anwar]

On 20/01/24 2:10 am, Simon Horman wrote:
> On Thu, Jan 18, 2024 at 12:40:04PM +0530, MD Danish Anwar wrote:
> 
> ...
> 
>> @@ -211,6 +216,15 @@ struct prueth_pdata {
>>   * @iep0: pointer to IEP0 device
>>   * @iep1: pointer to IEP1 device
>>   * @vlan_tbl: VLAN-FID table pointer
>> + * @hw_bridge_dev: pointer to HW bridge net device
>> + * @br_members: bitmask of bridge member ports
>> + * @prueth_netdevice_nb: netdevice notifier block
>> + * @prueth_switchdevice_nb: switchdev notifier block
> 
> nit: s/prueth_switchdevice_nb/prueth_switchdev_nb/
> 
>      Flagged by ./scripts/kernel-doc -none>

Sure Simon. I will fix this.

>> + * @prueth_switchdev_bl_nb: switchdev blocking notifier block
>> + * @is_switch_mode: flag to indicate if device is in Switch mode
>> + * @is_switchmode_supported: indicates platform support for switch mode
>> + * @switch_id: ID for mapping switch ports to bridge
>> + * @default_vlan: Default VLAN for host
>>   */
>>  struct prueth {
>>  	struct device *dev;
>> @@ -236,6 +250,16 @@ struct prueth {
>>  	struct icss_iep *iep0;
>>  	struct icss_iep *iep1;
>>  	struct prueth_vlan_tbl *vlan_tbl;
>> +
>> +	struct net_device *hw_bridge_dev;
>> +	u8 br_members;
>> +	struct notifier_block prueth_netdevice_nb;
>> +	struct notifier_block prueth_switchdev_nb;
>> +	struct notifier_block prueth_switchdev_bl_nb;
>> +	bool is_switch_mode;
>> +	bool is_switchmode_supported;
>> +	unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN];
>> +	int default_vlan;
>>  };
>>  
>>  struct emac_tx_ts_response {
> 
> ...

-- 
Thanks and Regards,
Danish