Re: [PATCH 8/8] arm64: dts: qcom: ipq5018-rdp432-c2: enable ethernet support

[Krzysztof Kozlowski]

On 21/01/2024 13:42, Ziyang Huang wrote:
> Signed-off-by: Ziyang Huang <hzyitc@xxxxxxxxxxx>

Missing commit msg.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts_getmaintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, use mainline), work on fork of kernel (don't, use
mainline) or you ignore some maintainers (really don't). Just use b4 and
all the problems go away.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.


> ---
>  .../arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts
> index e636a1cb9b77..074b78d7939c 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts
> @@ -15,6 +15,9 @@ / {
>  
>  	aliases {
>  		serial0 = &blsp1_uart1;
> +

Drop.

> +		ethernet0 = &gmac0;
> +		ethernet1 = &gmac1;

Keep alphabetical order.

>  	};
>  
>  	chosen {
> @@ -43,6 +46,22 @@ &sleep_clk {
>  };
>  
>  &tlmm {
> +	mdio1_pins: mdio1_pins {

This wasn't ever tested. NAK.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).


Best regards,
Krzysztof