RE: [PATCH 1/2] x86: Remove dynamic NOP selection

From: H. Peter Anvin
Date: Sun Jan 21 2024 - 18:12:01 EST


On January 21, 2024 2:36:32 PM PST, David Laight <David.Laight@xxxxxxxxxx> wrote:
>From: Linus Torvalds
>> Sent: 20 January 2024 17:00
>...
>> And if I add "-r" to get relocation info, I get
>>
>> call <delayed_put_task_struct+0x1a>
>> R_X86_64_PLT32 rethook_flush_task-0x4
>>
>> which shows the raw relocation data, but with truly mind-bogglingly
>> horrendous syntax.
>>
>> Is there some sane tool that just does the sane thing and shows this as
>>
>> call rethook_flush_task
>>
>> which is what the thing actually means?
>
>While you are re-writing a disassembler, remember to print the
>contents of string when you get a reference into .rodata.str :-)
>
>How many times have you had to dig out a printf format string in
>order to locate the source associated with some object code?
>It is so much easier if the disassembler does it for you.
>
> David
>
>-
>Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
>Registration No: 1397386 (Wales)
>

Probably don't even need to rewrite the disassembler. Postprocessing is probably sufficient.