Re: [PATCH] spi: s3c64xx: Extract FIFO depth calculation to a dedicated macro

From: Andi Shyti
Date: Sun Jan 21 2024 - 15:24:13 EST


Hi Sam,

> void __iomem *regs = sdd->regs;
> unsigned long val = 1;
> u32 status;
> -
> - /* max fifo depth available */
> - u32 max_fifo = (FIFO_LVL_MASK(sdd) >> 1) + 1;
> + u32 max_fifo = FIFO_DEPTH(sdd);

Why have you removed the comment? Perhaps you could place it on
the side in order to remove that awful space.

Not a biding comment, though:

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Andi