Re: lib/vsprintf.c:1528:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute

From: Andy Shevchenko
Date: Sun Jan 21 2024 - 08:55:07 EST


On Thu, Jan 11, 2024 at 10:33:09AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: acc657692aed438e9931438f8c923b2b107aebf9
> commit: 45c3e93d751ea50861c796da3cbfc848fa6ddf55 vsprintf: Factor out %pV handler as va_format()
> date: 4 years, 9 months ago

Blast from the past?!

..

> All warnings (new ones prefixed by >>):
>
> lib/vsprintf.c:625:7: warning: no previous prototype for 'pointer_string' [-Wmissing-prototypes]
> 625 | char *pointer_string(char *buf, char *end, const void *ptr,
> | ^~~~~~~~~~~~~~

ce9d3eceb7ff ("lib/vsprintf: Make function pointer_string static")

..

> lib/vsprintf.c: In function 'va_format':
> >> lib/vsprintf.c:1528:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
> 1528 | buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
> | ^~~

This might be still valid, but I have no idea how to properly fix it.

--
With Best Regards,
Andy Shevchenko