Re: [cocci] [v2] coccinelle: device_attr_show: Adapt to the latest Documentation/filesystems/sysfs.rst

From: Julia Lawall
Date: Sun Jan 21 2024 - 06:00:18 EST




On Sun, 21 Jan 2024, Markus Elfring wrote:

> > I subsequently simplified the patch case to contain the following:
> >
> > - snprintf(BUF, SZ, FORMAT
> > + sysfs_emit(BUF, FORMAT
> > ,...);
> >
> > This also works for the case where there are only three arguments.
> > It has the benefit that the change is recognized as a line replacement, so
> > no extra {} are added when the call is in an if branch.
>
> Would you like to consider the application of the following SmPL code variant?
>
> -snprintf
> +sysfs_emit
> (BUF,
> - SZ,
> FORMAT,
> ...
> );

It's ok too.

julia

>
> Regards,
> Markus
>