Re: [RFC PATCH v2] keys: update key quotas in key_put()

[Jarkko Sakkinen]

On Mon Jan 15, 2024 at 12:03 PM UTC, Luis Henriques wrote:
> Delaying key quotas update when key's refcount reaches 0 in key_put() has
> been causing some issues in fscrypt testing.  This patches fixes this test
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
						This commit fixes the test

> flakiness by dealing with the quotas immediately, but leaving all the other
> clean-ups to the key garbage collector.  Unfortunately, this means that we
> also need to switch to the irq-version of the spinlock that protects quota.

The commit message fails to describe the implementation changes.

You have a motivation paragraph but you also need to add implementation
paragraph, which describes how the code changes reflect the motivation.

BR, Jarkko