Re: [PATCH] HID: nintendo: Remove some unused functions

[Silvan Jegen]

Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
> These functions are defined in the hid-nintendo.c file, but not called
> elsewhere, so delete these unused functions.
> 
> drivers/hid/hid-nintendo.c:670:20: warning: unused function 'joycon_device_is_left_joycon'.
> drivers/hid/hid-nintendo.c:674:20: warning: unused function 'joycon_device_is_right_joycon'
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7992
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/hid/hid-nintendo.c | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Silvan Jegen <s.jegen@xxxxxxxxx>


> 
> diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
> index ccc4032fb2b0..7ce6be0a8dee 100644
> --- a/drivers/hid/hid-nintendo.c
> +++ b/drivers/hid/hid-nintendo.c
> @@ -667,16 +667,6 @@ struct joycon_ctlr {
>   * These helpers are most useful early during the HID probe or in conjunction
>   * with the capability helpers below.
>   */
> -static inline bool joycon_device_is_left_joycon(struct joycon_ctlr *ctlr)
> -{
> -	return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_JOYCONL;
> -}
> -
> -static inline bool joycon_device_is_right_joycon(struct joycon_ctlr *ctlr)
> -{
> -	return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_JOYCONR;
> -}
> -
>  static inline bool joycon_device_is_procon(struct joycon_ctlr *ctlr)
>  {
>  	return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_PROCON;