Re: [PATCH v1 18/26] crypto: ccp: Handle legacy SEV commands when SNP is enabled

From: Borislav Petkov
Date: Fri Jan 19 2024 - 12:49:31 EST


On Fri, Jan 19, 2024 at 11:36:44AM -0600, Tom Lendacky wrote:
> Using %#x will produce the 0x in the output (except if the value is zero for
> some reason).

printf-compatibility:

# The value should be converted to an "alternate form". For o conversions,
the first character of the output string is made zero (by prefixing a 0
if it was not zero already). For x and X conversions, a nonzero result
has the string "0x" (or "0X" for X conversions) prepended to it.

> So I would say make that 0x%x.

Yap, better, unambiguous.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette