Re: [PATCH v3] tracing: Support to dump instance traces by ftrace_dump_on_oops

[Steven Rostedt]

On Fri, 19 Jan 2024 16:08:24 +0800
Huang Yiwei <quic_hyiwei@xxxxxxxxxxx> wrote:

> -	ftrace_dump_on_oops[=orig_cpu]
> +	ftrace_dump_on_oops[=orig_cpu | =<instance>]

I wonder if we should have it be:

	ftrace_dump_on_oops[=orig_cpu | =<instance> | =<instance>:orig_cpu ]

Then last would be to only print out a specific CPU trace of the given instance.

And if we really want to be fancy!

	ftrace_dump_on_opps[=orig_cpu | =<instance> | =orig_cpu:<instance> ][,<instance> | ,<instance>:orig_cpu]

That would allow dumping more than one instance.

If you want to dump the main buffer and an instance foo:

	ftrace_dump_on_opps,foo

Where the ',' says to dump the top instance as well as the foo instance.

-- Steve


>  			[FTRACE] will dump the trace buffers on oops.
> -			If no parameter is passed, ftrace will dump
> -			buffers of all CPUs, but if you pass orig_cpu, it will
> +			If no parameter is passed, ftrace will dump global
> +			buffers of all CPUs, if you pass orig_cpu, it will
>  			dump only the buffer of the CPU that triggered the
> -			oops.
> +			oops, or specific instance will be dumped if instance
> +			name is passed.
>