Re: [PATCH net v2 2/2] net: micrel: Fix set/get PHC time for lan8814

From: Andrew Lunn
Date: Fri Jan 19 2024 - 08:07:30 EST


On Thu, Jan 18, 2024 at 09:59:16AM +0100, Horatiu Vultur wrote:
> When setting or getting PHC time, the higher bits of the second time (>32
> bits) they were ignored. Meaning that setting some time in the future like
> year 2150, it was failing to set this.
>
> The issue can be reproduced like this:
>
> # phc_ctl /dev/ptp1 set 10000000000
> phc_ctl[118.619]: set clock time to 4294967295.000000000 or Sun Feb 7 06:28:15 2106
>
> # phc_ctl /dev/ptp1 get
> phc_ctl[120.858]: clock time is 1.238620924 or Thu Jan 1 00:00:01 1970
>
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> Reviewed-by: Divya Koppera <divya.koppera@xxxxxxxxxxxxx>

When submitted to net-next:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew