Re: [PATCH] dmaengine: sh: rz-dmac: Avoid format-overflow warning

From: Vinod Koul
Date: Fri Jan 19 2024 - 07:50:59 EST



On Wed, 10 Jan 2024 22:27:17 +0000, Prabhakar wrote:
> The max channel count for RZ DMAC is 16, hence use u8 instead of unsigned
> int and make the pdev_irqname string long enough to avoid the warning.
>
> This fixes the below issue:
> drivers/dma/sh/rz-dmac.c: In function ‘rz_dmac_probe’:
> drivers/dma/sh/rz-dmac.c:770:34: warning: ‘%u’ directive writing between 1 and 10 bytes into a region of size 3 [-Wformat-overflow=]
> 770 | sprintf(pdev_irqname, "ch%u", index);
> | ^~
> In function ‘rz_dmac_chan_probe’,
> inlined from ‘rz_dmac_probe’ at drivers/dma/sh/rz-dmac.c:910:9:
> drivers/dma/sh/rz-dmac.c:770:31: note: directive argument in the range [0, 4294967294]
> 770 | sprintf(pdev_irqname, "ch%u", index);
> | ^~~~~~
> drivers/dma/sh/rz-dmac.c:770:9: note: ‘sprintf’ output between 4 and 13 bytes into a destination of size 5
> 770 | sprintf(pdev_irqname, "ch%u", index);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]

Applied, thanks!

[1/1] dmaengine: sh: rz-dmac: Avoid format-overflow warning
commit: c4d6dcb3b6250ea546a952ad33382daf7cd32425

Best regards,
--
~Vinod