Re: [PATCH v2 1/2] dt-bindings: backlight: add Kinetic KTD2801 binding

From: Linus Walleij
Date: Fri Jan 19 2024 - 03:48:30 EST


Hi Duje,

thanks for your patch!

On Thu, Jan 18, 2024 at 6:33 PM Duje Mihanović <duje.mihanovic@xxxxxxxx> wrote:

> Add the dt binding for the Kinetic KTD2801 backlight driver.

Maybe add some commit message?

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx>
(...)
> + ctrl-gpios:
> + maxItems: 1

First I thought this was inconsistent with ktd253, then
I looked at the datasheets and they really did change "en" to "ctrl" so
this needs a new name indeed.

With commit message added:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij