Re: [PATCH] HID: nvidia-shield: Add some null pointer checks to the hid-nvidia-shield.c

From: Rahul Rameshbabu
Date: Fri Jan 19 2024 - 01:23:14 EST


On Fri, 19 Jan, 2024 14:07:14 +0800 Kunwu Chan <chentao@xxxxxxxxxx> wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
>
> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
> ---

Just one comment about the subject for future submissions (this one is
fine). I would just leave the subject as "HID: nvidia-shield: Add some
null pointer checks". We know what file is being edited from the commit
content, so the additional filename detail isn't necessary.

Thanks for the patch. Really appreciate it.

Reviewed-by: Rahul Rameshbabu <rrameshbabu@xxxxxxxxxx>