Re: [PATCH v3 0/4] Allow coreboot modules to autoload and enable cbmem in the arm64 defconfig

From: Tzung-Bi Shih
Date: Thu Jan 18 2024 - 21:39:38 EST


On Wed, Jan 17, 2024 at 04:03:21PM -0300, Nícolas F. R. A. Prado wrote:
> This series adds the missing pieces to the coreboot bus and the module
> alias generation to allow coreboot modules to be automatically loaded
> when matching devices are detected.
>
> The configs for cbmem coreboot entries are then enabled in the arm64
> defconfig, as modules, to allow reading logs from coreboot on arm64
> Chromebooks, which is useful for debugging the boot process.
>
> Changes in v3:
> - Merged all "add to module device table" commits into a single commit
> which also changes the coreboot_driver struct to contain an id table
> and avoid unused variable warnings for the id tables.
>
> Changes in v2:
> - Added commits for vpd, memconsole and framebuffer drivers to add them
> to the module device table
>
> ---
> Nícolas F. R. A. Prado (4):
> firmware: coreboot: Generate modalias uevent for devices
> firmware: coreboot: Generate aliases for coreboot modules
> firmware: coreboot: Replace tag with id table in driver struct
> arm64: defconfig: Enable support for cbmem entries in the coreboot table

The series overall looks good to me.

I'm happy to queue all the patches into chrome-platform-firmware for the next
merge window (i.e. for v6.9-rc1). Let's wait a bit for the maintainers for
the other subsystems if they are OK with that.