Re: [PATCH] drivers: watchdog: Add ChromeOS EC watchdog

[Guenter Roeck]

On 1/18/24 10:08, Łukasz Majczak wrote:
> Hi Guenter
>
> Please see my comments below
>
> On Wed, Jan 17, 2024 at 5:23 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > On 1/17/24 02:24, Lukasz Majczak wrote:
> > > This adds EC-based watchdog support for ChromeOS
> > > based devices equipped with embedded controller (EC).
> > >
> > > Signed-off-by: Lukasz Majczak <lma@xxxxxxxxxxxx>
> >
> > checkpatch --strict says:
> >
> > total: 0 errors, 0 warnings, 14 checks, 455 lines checked
> >
> > Please fix.
>
> ACK, Although I would keep uint16_t/uint32_t types in
> cros_ec_commands.h as those are shared with EC firmware.

Makes sense. Thanks!

Guenter