Re: [PATCH v2 08/17] serial: max310x: use separate regmap name for each port

From: Andy Shevchenko
Date: Thu Jan 18 2024 - 10:31:41 EST


On Thu, Jan 18, 2024 at 5:22 PM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote:
>
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> Use a separate regmap name for each port so they can each have their own
> debugfs entry, allowing to access each port registers independently.
>
> For example, a four channels/ports device like the MAX14830 will have four
> entries in its regmap debugfs:
>
> $ find /sys/kernel/debug/regmap -type d | grep spi0.0

Just a side note for the future. The above is an example of "Useless
use of grep".
`find` has a `-name` parameter for such, using `find ...-name
'spi0.0*'` makes the grep unnecessary.

> /sys/kernel/debug/regmap/spi0.0-port0
> /sys/kernel/debug/regmap/spi0.0-port1
> /sys/kernel/debug/regmap/spi0.0-port2
> /sys/kernel/debug/regmap/spi0.0-port3

--
With Best Regards,
Andy Shevchenko