Re: [PATCH] media: atomisp: ssh_css: Fix a null-pointer dereference in load_video_binaries

From: alexious
Date: Thu Jan 18 2024 - 10:11:55 EST


> On Wed, Jan 17, 2024 at 8:34 AM <alexious@xxxxxxxxxx> wrote:
> > > On Fri, Jan 12, 2024 at 10:49 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > > > On 1/12/24 09:34, Zhipeng Lu wrote:
>
> > > > > Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> > > Besides that, are you sure the Fixes refers to the correct commit?
> >
> > Well, I think I referred to the correct commit, which introduce the whole module and leave this bug.
> >
> > If I did miss something please let me know.
>
> Yes, the driver was before that commit in the kernel. Was it without
> the bug? No, because you are referring to a clear revert. So, find the
> real commit that had brought that into the kernel.

You are correct, I just did some git blame on the latest version but
forgot about the commit blamed was a revert commit.
A v2 version of this patch will be sent later to fix this issue.
Thank you for pointing out my mistake.

Regards,
Zhipeng

>
> --
> With Best Regards,
> Andy Shevchenko