RE: [PATCH v4 1/2] KVM: VMX: Cleanup VMX basic information defines and usages

[Li, Xin3]

> > > > 	 * KVM does not emulate a version of VMX that constrains physical
> > > > 	 * addresses of VMX structures (e.g. VMCS) to 32-bits.
> > > > 	 */
> > > > -	if (data & BIT_ULL(48))
> > > > +	if (data & VMX_BASIC_32BIT_PHYS_ADDR_ONLY)
> > > > 		return -EINVAL;
> > >
> > > Side topic:
> > >
> > > Actually, there is no need to handle bit 48 as a special case. If we
> > > add bit 48 to VMX_BASIC_FEATURES_MASK, the bitwise check will fail if bit 48
> of @data is 1.
> >
> > Good point!  This is also what you suggested above.
> >
> 
> Please try to avoid mixing things together in one patch.  If you want to do above,
> could you please do it in a separate patch so that can be reviewed separately?
> 
> E.g., people who have reviewed or acked this patch may not be interested in the
> new (logically separate) things.

I got to echo what Chao has suggested.

Yeah, if we are going to make this change in this patch set, it has to
be a new patch.  It can also be a separate patch.