Re: [PATCH 0/2] mm/zswap: optimize the scalability of zswap rb-tree
From: Chris Li
Date: Wed Jan 17 2024 - 20:03:49 EST
Hi Yosry,
On Wed, Jan 17, 2024 at 4:35 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote:
> Hmm I don't understand. What's the point of keeping the rbtree if we
> have the xarray? Doesn't it end up being more expensive and bug-prone
> to maintain both trees?
Patch 2/2 remove the rb tree code. Just keeping the tree spinlock.
>
> When you say "eventual goal", do you mean what the patch would morph
> into in later versions (as in v1 is just a proof of concept without
> removing the rbtree), or follow up patches?
V1 will remove the rb tree, but does not merge the rb tree lock with
the xarray lock.
Hi Nhat,
> Hmmm why? Is there a reason to keep the rb tree around?
No, not at all.
Chris