Re: [PATCH 15/18] serial: max310x: replace ENOTSUPP with preferred EOPNOTSUPP (checkpatch)

From: Andy Shevchenko
Date: Wed Jan 17 2024 - 18:25:00 EST


On Thu, Jan 18, 2024 at 12:39 AM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote:
>
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> Fixes the following checkpatch warning:
>
> WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP

NAK.
It's a false positive.

> According to include/linux/errno.h, ENOTSUPP is
> "Defined for the NFSv3 protocol", so replace it with preferred EOPNOTSUPP.

The GPIO subsystem uses this internal error code internally. User
space won't get it, so users may not see this one.

--
With Best Regards,
Andy Shevchenko