Re: [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588

[Heiko Stübner]

Hi Nicolas,

Am Mittwoch, 17. Januar 2024, 20:16:24 CET schrieb Nicolas Dufresne:
> Le dimanche 31 décembre 2023 à 23:11 +0800, Jianfeng Liu a écrit :
> > This is the v3 version of this series adding hantro g1 video decoder
> > support for rk3588.
> > 
> > RK3588 has Hantro G1 video decoder known as VDPU121 in TRM of RK3588 which
> > is capable to decode MPEG2/H.264/VP8 up to 1920x1088. This vpu ip is also
> > found in RK3568.
> 
> The only concern I have is that we rejected enabling this VPU on RK3399, since
> having two H.264 decoders was confusing userspace softwares at the time, causing
> the slow one to be picked sometimes. I know the selection is not fully
> implemented in GStreamer either, not sure for LibreELEC ffmpeg fork, Chromium or
> Cros-codec.
> 
> Of course, its not a problem now, but only when someone provides an rkvdec2
> driver that enables the much more capable HW decoder. Shall we hold on H.264
> mainline for now ?

hmm, reading the TRM the VDPU121 claims to support:
- VP8
- VC1
- MPEG-1,2,4
- H.263
- JPEG

So at least the TRM doesn't list h.264 as supported at all on VDPU121 .
Not sure what is up with that or is Rockchip also just suggesting that h.264
should be in the VDPU381 [where h.264 is listed as featured] ?


Heiko