Re: [PATCH] afs: Fix missing/incorrect unlocking of RCU read lock

[Marc Dionne]

On Wed, Jan 17, 2024 at 12:21 PM David Howells <dhowells@xxxxxxxxxx> wrote:
>
> David Howells <dhowells@xxxxxxxxxx> wrote:
>
> > In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in both
> > places before returning (and not lock it again).
> >
> > Fixes: f94f70d39cc2 ("afs: Provide a way to configure address priorities")
> > Reported-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>
>
> Actually:
>
> Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@xxxxxxxxx
> > Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> > cc: linux-afs@xxxxxxxxxxxxxxxxxxx
> > cc: linux-fsdevel@xxxxxxxxxxxxxxx
>
> David

The fix looks fine.

Reviewed-by: Marc Dionne <marc.dionne@xxxxxxxxxxxx>

Marc