Re: [PATCH 1/3] dt-bindings: rockchip: Add rk809 support for rk817 audio codec

From: Tim Lunn
Date: Wed Jan 17 2024 - 06:08:51 EST



On 1/17/24 21:57, Krzysztof Kozlowski wrote:
On 17/01/2024 11:38, Tim Lunn wrote:
On 1/17/24 21:12, Krzysztof Kozlowski wrote:
On 17/01/2024 10:37, Tim Lunn wrote:
You can drop the description.
Yes just 1 clock, i will fix this.
+
+ clock-names:
+ description:
+ The clock name for the codec clock.
Drop.
Just drop the description? I dont think can drop the clock names as the
driver use the name to lookup clock:
Description. But anyway the problem is that adding clocks should be
separate patch with its own explanation.

Right, but I am not actually adding any clocks, just documenting what is
already there.
You are. Binding did not have any clocks, now it has.
Ok, I will split the clocks into a separate patch.

There are already boards using this codec with rk809 in dts files and is
working fine from driver side.


Best regards,
Krzysztof