RE: [PATCH net v3 3/3] dpll: fix userspace availability of pins

From: Kubalewski, Arkadiusz
Date: Wed Jan 17 2024 - 04:19:42 EST


>From: Jiri Pirko <jiri@xxxxxxxxxxx>
>Sent: Tuesday, January 16, 2024 8:47 AM
>
>Mon, Jan 15, 2024 at 09:52:41AM CET, arkadiusz.kubalewski@xxxxxxxxx wrote:
>>If parent pin was unregistered but child pin was not, the userspace
>>would see the "zombie" pins - the ones that were registered with
>>a parent pin (dpll_pin_on_pin_register(..)).
>>Technically those are not available - as there is no dpll device in the
>>system. Do not dump those pins and prevent userspace from any
>>interaction with them. Provide a unified function to determine if the
>>pin is available and use it before acting/responding for user requests.
>>
>>Fixes: 9431063ad323 ("dpll: core: Add DPLL framework base functions")
>>Fixes: 9d71b54b65b1 ("dpll: netlink: Add DPLL framework base functions")
>>Reviewed-by: Jan Glaza <jan.glaza@xxxxxxxxx>
>>Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@xxxxxxxxx>
>
>The patch looks fine, but it should come before the previous one.
>
>pw-bot: cr
>
>Feel free to attach the review tag to the next version you send:
>Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>

Fixed in v4.

Thank you!
Arkadiusz