Re: [PATCH] block: fix length of strscpy()

From: Guoxin Pu
Date: Wed Jan 17 2024 - 01:12:01 EST


On 02/01/2024 05:26, Jens Axboe wrote:
On 1/1/24 10:50 AM, Guoxin Pu wrote:
In commit 146afeb235ccec10c17ad8ea26327c0c79dbd968 ("block: use strscpy()
to instead of strncpy()") , the length that should now represent the length
of the string with the terminating NULL was not updated alongside the
change.

This has caused blkdevparts= definition on kernel cmdline to be not
correctly recognized and partitions not correctly initialized, breaking any
device relying on such partitions to boot, on stable releases since 6.6

This patch fixes the lengths to contain the terminating NULL.
This needs a Fixes line.

Sorry for the late reply.

Thank you for the review. The Fixes line was added and I've sent the new patch as "[PATCH v2] block: fix length of strscpy()" earlier on Jan, 2nd.

And since 6.7 is out, do I need to rework the v2 patch and add cc stable 6.7.x?